Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snake_oil.ert #7075

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Update snake_oil.ert #7075

merged 1 commit into from
Feb 1, 2024

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

oyvindeide
oyvindeide requested changes Feb 1, 2024
View reviewed changes
test-data/snake_oil/snake_oil.ert Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66412cf) 83.73% compared to head (f2b7ed4) 83.71%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7075      +/-   ##
==========================================
- Coverage   83.73%   83.71%   -0.03%     
==========================================
  Files         367      367              
  Lines       22138    22138              
  Branches     1011     1011              
==========================================
- Hits        18538    18533       -5     
- Misses       3286     3291       +5     
  Partials      314      314

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oyvindeide
oyvindeide approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@oyvindeide oyvindeide left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating

@frode-aarstad frode-aarstad merged commit 6b7eb02 into main Feb 1, 2024
51 of 52 checks passed
@frode-aarstad frode-aarstad deleted the frode-aarstad-patch-1 branch February 1, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindeide oyvindeide oyvindeide approved these changes

@sondreso sondreso sondreso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frode-aarstad @codecov-commenter @sondreso @oyvindeide